remove hardcoded ldap libdir in Dockerfile #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @MilkWithCoffee, thanks for your pull request. I can't see any problems with this. Also all the checks have passed through the ci so we can integrate. I'll merge it and it will be in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this repo to be regularly updated (thank you!) and thus I am using it to host a bookstack container on raspberry pi. For this purpose, I am rebuilding the image on the device with the Dockerfile provided. It works flawless despite one line:
docker-bookstack/Dockerfile
Line 9 in 2ccba9a
Obviously, the path lib/x86_64-linux-gnu does not exist on arm architecture. Removing the argument results in a successful build both on arm as well as amd64 systems.
As far as I see, the argument can be omitted to gain compatibility for arm. Let me know if I am missing anything.